Skip to content

Revert "nrf_security: Enable NRF_RNG_ENTROPY_DRIVER for fake entropy" #25275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2025
Merged

Revert "nrf_security: Enable NRF_RNG_ENTROPY_DRIVER for fake entropy" #25275

merged 2 commits into from
Nov 3, 2025

Conversation

@seko-nordic
Copy link
Contributor

@seko-nordic seko-nordic commented Oct 28, 2025

This reverts commit ed84479.
PSA entropy is in place so fake entropy must not be used any longer.

@seko-nordic seko-nordic requested review from a team as code owners October 28, 2025 11:10
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 28, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 28, 2025 •
edited
Loading

CI Information

To view the history of this post, click the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 42a16e73befb53a9ffa1e4db98d47fd156766d26
zephyr: PR head: c1c66b9cffad1fea2d0b9d4c028f33ebe438dc3f

more details

sdk-nrf:

PR head: 42a16e73befb53a9ffa1e4db98d47fd156766d26
merge base: 4b82c0efcf76aeb2227bfd7df4ee899ed2d05e56
target head (main): 4b82c0efcf76aeb2227bfd7df4ee899ed2d05e56
Diff

zephyr:

PR head: c1c66b9cffad1fea2d0b9d4c028f33ebe438dc3f
merge base: 1b82b097aa67086d5a326049ebcb23510ddab77a
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (12) 
subsys
│  ├── nrf_security
│  │  ├── src
│  │  │  ├── drivers
│  │  │  │  ├── zephyr
│  │  │  │  │  ├── Kconfig
│  │  │  │  │  │ nrf_rng_entropy.c
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf54h20dk
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.dts
│  │  │  │  │ nrf54h20dk_nrf54h20_cpurad.dts
│  │  │  ├── nrf9280pdk
│  │  │  │  ├── nrf9280pdk_nrf9280_cpuapp.dts
│  │  │  │  │ nrf9280pdk_nrf9280_cpurad.dts
│  ├── drivers
│  │  ├── entropy
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── Kconfig.nrf_prng
│  │  │  │ fake_entropy_nrf_prng.c
│  ├── dts
│  │  ├── bindings
│  │  │  ├── rng
│  │  │  │  │ nordic,nrf-prng.yaml

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ test_ble_nrf_config
    • ◻️ test-fw-nrfconnect-chip
    • ◻️ test-fw-nrfconnect-nfc
    • ◻️ test-fw-nrfconnect-nrf_crypto
    • ◻️ test-fw-nrfconnect-rs
    • ◻️ test-fw-nrfconnect-fem
    • ◻️ test-fw-nrfconnect-tfm
    • ◻️ test-sdk-find-my
    • ◻️ test-low-level
    • ◻️ test-sdk-mcuboot
    • ◻️ test-sdk-dfu
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-thread-main
    • test-sdk-audio
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

You can find the documentation preview for this PR here.

@seko-nordic seko-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 28, 2025
tomi-font
tomi-font approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it more clear that it's a revert by changing commit title to nrf_security: Revert "Enable NRF_RNG_ENTROPY_DRIVER for fake entropy"?

@tomi-font tomi-font requested review from Vge0rge and frkv October 29, 2025 06:26
nordicjm
nordicjm requested changes Oct 29, 2025
View reviewed changes
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 30, 2025
@NordicBuilder NordicBuilder requested review from a team October 30, 2025 11:38
@seko-nordic seko-nordic changed the title nrf_security: Enable NRF_RNG_ENTROPY_DRIVER for fake entropy Revert nrf_security: Revert "Enable NRF_RNG_ENTROPY_DRIVER for fake entropy" Oct 30, 2025
@seko-nordic seko-nordic changed the title nrf_security: Revert "Enable NRF_RNG_ENTROPY_DRIVER for fake entropy" Revert "nrf_security: Enable NRF_RNG_ENTROPY_DRIVER for fake entropy" Oct 30, 2025
@seko-nordic seko-nordic mentioned this pull request Oct 31, 2025
Closed
@seko-nordic seko-nordic requested review from a team as code owners October 31, 2025 12:17
@NordicBuilder NordicBuilder requested a review from a team October 31, 2025 12:18
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 31, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@1b82b09 nrfconnect/sdk-zephyr@c1c66b9 (main) nrfconnect/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@seko-nordic
manifest: Update sdk-zephyr revision
42a16e7 
That reverts fake entropy nRF PRNG driver

Signed-off-by: Sergey Korotkov <[email protected]>
@NordicBuilder NordicBuilder removed the DNM label Nov 3, 2025
@rlubos rlubos merged commit 85816ce into nrfconnect:main Nov 3, 2025
19 of 20 checks passed
@seko-nordic seko-nordic deleted the fake_entropy_revert branch November 3, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rlubos rlubos rlubos approved these changes

@nordicjm nordicjm nordicjm approved these changes

@tomi-font tomi-font tomi-font approved these changes

@ayla-nordicsemi ayla-nordicsemi ayla-nordicsemi approved these changes

@Vge0rge Vge0rge Awaiting requested review from Vge0rge

@frkv frkv Awaiting requested review from frkv

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-zephyr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@seko-nordic @NordicBuilder @rlubos @nordicjm @tomi-font @ayla-nordicsemi